Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: claim ABI version for Electron v17 #40320

Closed
wants to merge 1 commit into from
Closed

doc: claim ABI version for Electron v17 #40320

wants to merge 1 commit into from

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 5, 2021

Claiming a version for the next major Electron release.

@miniak
doc: claim ABI version for Electron v17
afb04d2 
Claiming a version for the next major Electron release.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 5, 2021
@miniak miniak mentioned this pull request Oct 5, 2021
Merged
2 tasks
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

Landed in 09e8e14...1fc1b0f

@github-actions github-actions bot closed this Oct 7, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2021
@miniak @nodejs-github-bot
doc: claim ABI version for Electron v17
1fc1b0f 
Claiming a version for the next major Electron release.

PR-URL: #40320
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@miniak miniak deleted the patch-1 branch October 7, 2021 17:22
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@miniak @jasnell @targos @cjihrig @tniessen @richardlau @nodejs-github-bot